Update cryptography dependency, add pytest and bump the package version to 3.4.0#107
Open
abhakash wants to merge 1 commit intoojarva:masterfrom
Open
Update cryptography dependency, add pytest and bump the package version to 3.4.0#107abhakash wants to merge 1 commit intoojarva:masterfrom
abhakash wants to merge 1 commit intoojarva:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The package version in PyPI is still dependent on ecdsa, which has a vulnerability CVE-2024-23342. The latest version was never published.
This change aims to upgrade the package version to 3.4.0 and upgrade other dependencies.
Changes in the PR
Testing
Tests via pytest ran successfully.
Github CI run :
https://github.com/abhakash/python-sshpubkeys/actions/runs/12703787314
Let me know if any additional testing is required. Or if the package versioning should be changed.